mridulm commented on a change in pull request #34043:
URL: https://github.com/apache/spark/pull/34043#discussion_r714097032
##########
File path:
core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
##########
@@ -573,39 +576,41 @@ class BlockManagerMasterEndpoint(
blockId: BlockId,
storageLevel: StorageLevel,
memSize: Long,
- diskSize: Long): Boolean = {
+ diskSize: Long): Future[Boolean] = {
logDebug(s"Updating block info on master ${blockId} for ${blockManagerId}")
if (blockId.isShuffle) {
blockId match {
case ShuffleIndexBlockId(shuffleId, mapId, _) =>
// We need to update this at index file because there exists the
index-only block
logDebug(s"Received shuffle index block update for ${shuffleId}
${mapId}, updating.")
- mapOutputTracker.updateMapOutput(shuffleId, mapId, blockManagerId)
- return true
+ return Future {
+ mapOutputTracker.updateMapOutput(shuffleId, mapId, blockManagerId)
+ true
+ }
Review comment:
nit: Can we move the log statement into the future as well ? so that it
is emitted just before invoking updateMapOutput.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
