Swinky commented on a change in pull request #34062:
URL: https://github.com/apache/spark/pull/34062#discussion_r714135815
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/PartitionPruning.scala
##########
@@ -282,13 +284,13 @@ object PartitionPruning extends Rule[LogicalPlan] with
PredicateHelper with Join
// otherwise the pruning will not trigger
var filterableScan = getFilterableTableScan(l, left)
if (filterableScan.isDefined && canPruneLeft(joinType) &&
- hasPartitionPruningFilter(right)) {
+ hasPartitionPruningFilter(right, r)) {
Review comment:
I couldn't understand how can we do this filtering here, this should be
done recursively on all the filters in `right` plan, hence this is checked in
`hasSelectivePredicate`. Could you please elaborate in case I am missing
something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
