mridulm commented on pull request #34043: URL: https://github.com/apache/spark/pull/34043#issuecomment-925251026
@attilapiros I have not followed node decommissioning discussions in detail, hopefully @holdenk or @dongjoon-hyun can comment more here. When looking at the affected codepaths, `BlockManager` is not currently differentiating between the block id's in `tryToReportBlockStatus` when it is updating driver (normal and for block migration). Until node decommissioning, this path was used for non-shuffle blocks iirc. IMO handling the shuffle vs non-shuffle split while processing `UpdateBlockInfo` at driver is cleaner than spreading it out to caller; unless we have other issues in doing so (for example: MT-safety, correctness, design hygine, etc concerns). Thoughts ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
