cloud-fan commented on a change in pull request #34033:
URL: https://github.com/apache/spark/pull/34033#discussion_r714446914
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##########
@@ -562,6 +567,8 @@ case class InSet(child: Expression, hset: Set[Any]) extends
UnaryExpression with
protected override def nullSafeEval(value: Any): Any = {
if (set.contains(value)) {
true
+ } else if (isNaN(value)) {
+ set.exists(isNaN(_))
Review comment:
can we have a `hasNaN` variable to avoid repeated computing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
