AngersZhuuuu commented on a change in pull request #34033:
URL: https://github.com/apache/spark/pull/34033#discussion_r714515848
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##########
@@ -554,6 +554,12 @@ case class InSet(child: Expression, hset: Set[Any])
extends UnaryExpression with
}
@transient private[this] lazy val hasNull: Boolean = hset.contains(null)
+ @transient private[this] lazy val isNaN: Any => Boolean = child.dataType
match {
+ case DoubleType => (value: Any) =>
java.lang.Double.isNaN(value.asInstanceOf[java.lang.Double])
+ case FloatType => (value: Any) =>
java.lang.Float.isNaN(value.asInstanceOf[java.lang.Float])
+ case _ => (_: Any) => false
+ }
+ @transient private[this] lazy val hasNaN = set.exists(isNaN)
Review comment:
> nit: we can avoid iterating the set if type is not float/double.
DOne
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
