kazuyukitanimura commented on a change in pull request #34055:
URL: https://github.com/apache/spark/pull/34055#discussion_r714992083
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala
##########
@@ -488,6 +489,16 @@ object SimplifyBinaryComparison
// False with inequality
case a GreaterThan b if canSimplifyComparison(a, b,
notNullExpressions) => FalseLiteral
case a LessThan b if canSimplifyComparison(a, b, notNullExpressions)
=> FalseLiteral
+
+ // One side is Literal
+ case (a: Predicate) EqualTo TrueLiteral => a
Review comment:
Thanks, yes the intention is for pushing down the filter. I will add a
comment.
Actually, my original attempt, which I later changed to `Predicate` only,
was `case a EqualTo TrueLiteral if a.dataType.isInstanceOf[BooleanType]`. I
found that is too disruptive for some tests. I will keep it only for
`Predicate` for now, and we can still get the push down benefit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
