cloud-fan commented on a change in pull request #34080:
URL: https://github.com/apache/spark/pull/34080#discussion_r715012708
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
##########
@@ -54,7 +54,7 @@ case class EnsureRequirements(
assert(requiredChildDistributions.length == originalChildren.length)
assert(requiredChildOrderings.length == originalChildren.length)
// Ensure that the operator's children satisfy their output distribution
requirements.
- var newChildren = originalChildren.zip(requiredChildDistributions).map {
+ var children = originalChildren.zip(requiredChildDistributions).map {
Review comment:
I feel the original name `children` is better, as it's a `var` and we
keep updating it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
