HyukjinKwon commented on a change in pull request #34058:
URL: https://github.com/apache/spark/pull/34058#discussion_r715277365
##########
File path: python/pyspark/pandas/typedef/typehints.py
##########
@@ -793,11 +846,23 @@ def extract_types(params: Any) -> Tuple:
- DataFrame[index_type, [type, ...]]
- DataFrame[(index_name, index_type), [(name, type), ...]]
- DataFrame[dtype instance, dtypes instance]
- - DataFrame[(index_name, index_type), zip(names, types)]\n"""
+ - DataFrame[(index_name, index_type), zip(names, types)]
+ - DataFrame[[index_type, ...], [type, ...]]
+ - DataFrame[[(index_name, index_type), ...], [(name, type), ...]]
+ - DataFrame[dtypes instance, dtypes instance]
+ - DataFrame[zip(index_names, index_types), zip(names, types)]\n"""
+ "However, got %s." % str(origin)
)
+def _get_holder(is_index: bool) -> Union[Type[IndexNameTypeHolder],
Type[NameTypeHolder]]:
Review comment:
let's remove this method. It doesn't virtually remove the duplication by
dispatching on `is_index`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
