HyukjinKwon commented on a change in pull request #34051:
URL: https://github.com/apache/spark/pull/34051#discussion_r715282461
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala
##########
@@ -157,7 +161,8 @@ case class InSubqueryExec(
child = child.canonicalized,
plan = plan.canonicalized.asInstanceOf[BaseSubqueryExec],
exprId = ExprId(0),
- resultBroadcast = null)
+ resultBroadcast = null,
+ result = null)
Review comment:
Ah, yeah. It only copies the params in the constructor (I was confused
w/
https://github.com/databricks/scala-style-guide#case-classes-and-immutability):
```scala
scala> case class A() {
| @transient var a: String = _
| }
defined class A
scala> val a = A()
a: A = A()
scala> a.a
res1: String = null
scala> a.a = "b"
a.a: String = b
scala> a.copy().a
res2: String = null
scala> a.a
res3: String = b
```
In any event, we won't bother moving `result` to constructor I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
