mridulm commented on a change in pull request #34079:
URL: https://github.com/apache/spark/pull/34079#discussion_r715325832
##########
File path:
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
##########
@@ -284,7 +293,6 @@ static MergedShuffleFileManager
newMergedShuffleFileManagerInstance(TransportCon
// will also need the transport configuration.
return
mergeManagerSubClazz.getConstructor(TransportConf.class).newInstance(conf);
} catch (Exception e) {
- logger.error("Unable to create an instance of {}",
mergeManagerImplClassName);
Review comment:
I agree with @tgravescs, dropping the log message (particularly an
error) would be missing out on very useful debugging information.
One option would be to move it out of this class into some other util ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
