attilapiros commented on a change in pull request #33936:
URL: https://github.com/apache/spark/pull/33936#discussion_r715326783
##########
File path: repl/src/main/scala-2.12/org/apache/spark/repl/SparkILoop.scala
##########
@@ -105,6 +108,13 @@ class SparkILoop(in0: Option[BufferedReader], out:
JPrintWriter)
echo("Type :help for more information.")
}
+ override def processLine(line: String): Boolean = {
+ inactivityTimeout.stopInactivityTimer()
+ val result = super.processLine(line)
Review comment:
What happens when the line is evaluated and it throws an exception?
Do the underlying `processLine` guarantees that exceptions are not
propagated into the caller? Because if there is no such guarantees then we
should wrap this into a `try {..} finally {...}` and stop the timer in the
`finally`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
