sunchao commented on a change in pull request #34100:
URL: https://github.com/apache/spark/pull/34100#discussion_r715809142
##########
File path: launcher/pom.xml
##########
@@ -85,14 +85,33 @@
<version>${hadoop.version}</version>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>${hadoop-client-runtime.artifact}</artifactId>
- <version>${hadoop.version}</version>
- <scope>test</scope>
- </dependency>
</dependencies>
+ <profiles>
+ <profile>
+ <id>hadoop-2.7</id>
+ </profile>
+ <profile>
+ <id>hadoop-3.2</id>
+ <activation>
+ <activeByDefault>true</activeByDefault>
+ </activation>
+ <!--
+ Only declare for Hadoop 3.2 profile. Otherwise maven-shade-plugin may
stuck in an infinite
+ loop building the dependency-reduced pom, perhaps due to a maven bug:
+ https://issues.apache.org/jira/browse/MSHADE-148
Review comment:
Right, it's not fixed yet. See the last comment in the JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
