flyrain commented on pull request #34087: URL: https://github.com/apache/spark/pull/34087#issuecomment-926858351
> This basically looks OK to me, although I'm thinking whether it's better to make `ColumnarBatch` an abstract class: > This way we'll give data source implementors more flexibilities for the internal stuff and we don't have to be tied with `ColumnarBatchRow` and expose it also. @sunchao, I'm OK with an abstract class. We may still expose `ColumnarBatchRow` since any class extending the abstract class still needs it. Of course, they can implement their own version, but the logic'd most likely be same. One question for your code snippet, we should add the public method `rowIterator`, right? It is the major interface of the `ColumnarBatch`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
