cloud-fan commented on a change in pull request #34104:
URL: https://github.com/apache/spark/pull/34104#discussion_r716456008
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -330,7 +330,7 @@ class DataSourceV2Strategy(session: SparkSession) extends
Strategy with Predicat
SetCatalogAndNamespaceExec(catalogManager, catalogName, ns) :: Nil
case r: ShowCurrentNamespace =>
- ShowCurrentNamespaceExec(r.output, r.catalogManager) :: Nil
+ ShowCurrentNamespaceExec(r.output, r.catalogManager.get) :: Nil
Review comment:
We don't need to pass the catalog manager from logical plan to physical
plan, we can get it directly in the physical plan
```
val catalogManager = session.sessionState.catalogManager
...
```
see
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala#L60
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
