cloud-fan commented on a change in pull request #34070:
URL: https://github.com/apache/spark/pull/34070#discussion_r716490709
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/PartitionPruning.scala
##########
@@ -225,16 +230,6 @@ object PartitionPruning extends Rule[LogicalPlan] with
PredicateHelper with Join
}.isDefined
}
- /**
- * To be able to prune partitions on a join key, the filtering side needs to
- * meet the following requirements:
- * (1) it can not be a stream
- * (2) it needs to contain a selective predicate used for filtering
Review comment:
In your example, the "filtering side" is a very small parquet table with
300+ rows. I don't think that's a general case and can justify removing the
selective predicate check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
