copperybean commented on a change in pull request #34111:
URL: https://github.com/apache/spark/pull/34111#discussion_r716601773
##########
File path: build/mvn
##########
@@ -21,7 +21,12 @@ SELF=$(cd $(dirname $0) && pwd)
. "$SELF/util.sh"
if [ -z "${JAVA_HOME}" -a "$(command -v javac)" ]; then
- export JAVA_HOME="$(dirname $(dirname $(realpath $(command -v javac))))"
+ if [ x"$(uname -a | awk '{print $1}')" = xDarwin -a \
+ $(version $(sw_vers -productVersion)) -ge $(version 10.5) ]; then
Review comment:
According to the
[link](https://mkyong.com/java/how-to-set-java_home-environment-variable-on-mac-os-x/#what-is-usrlibexecjava-home),
`/usr/libexec/java_home` is a standard definition for macOS 10.5+.
We should assume that user should not destroy their OS environment by
replacing a standard command by another file.
As you mentioned, `uname -s` is better than my solution, I have change my
codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
