lxian commented on pull request #34098: URL: https://github.com/apache/spark/pull/34098#issuecomment-927786322
> The change looks good to me. > Do you want to do the same within `SparkEnv.stop` as well ? I've checked `SparkEnv.stop` and I didn't find obvious unchecked exceptions that would break the stop(). I think it may not be necessary to do the same try..catch to `SparkEnv.stop` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
