sarutak commented on a change in pull request #34111:
URL: https://github.com/apache/spark/pull/34111#discussion_r716756439
##########
File path: build/mvn
##########
@@ -21,7 +21,12 @@ SELF=$(cd $(dirname $0) && pwd)
. "$SELF/util.sh"
if [ -z "${JAVA_HOME}" -a "$(command -v javac)" ]; then
- export JAVA_HOME="$(dirname $(dirname $(realpath $(command -v javac))))"
+ if [ x"$(uname -a | awk '{print $1}')" = xDarwin -a \
+ $(version $(sw_vers -productVersion)) -ge $(version 10.5) ]; then
Review comment:
> it's irrelevant with the problem that what version of macOS is Java8
supported.
Building Spark with Maven requires Java 8
(https://spark.apache.org/docs/latest/building-spark.html#apache-maven).
Java 8 supports OS X 10.8.3+ and 10.9+.
So, someone who want to build with `build/mvn` should use 10.8.3+ or 10.9+.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
