cloud-fan commented on a change in pull request #34051:
URL: https://github.com/apache/spark/pull/34051#discussion_r717264538
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/PlanAdaptiveSubqueries.scala
##########
@@ -43,7 +43,7 @@ case class PlanAdaptiveSubqueries(
}
)
}
- InSubqueryExec(expr, subqueryMap(exprId.id), exprId)
+ InSubqueryExec(expr, subqueryMap(exprId.id), exprId, shouldBroadcast =
true)
Review comment:
Why should we broadcast here? It's DPP with AQE which is the default
case, and it's weird that your PR doesn't optimize the default case.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/PlanAdaptiveSubqueries.scala
##########
@@ -43,7 +43,7 @@ case class PlanAdaptiveSubqueries(
}
)
}
- InSubqueryExec(expr, subqueryMap(exprId.id), exprId)
+ InSubqueryExec(expr, subqueryMap(exprId.id), exprId, shouldBroadcast =
true)
Review comment:
Ah I see, thanks for the explaination!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
