Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5744#discussion_r29898483
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataType.scala ---
    @@ -43,7 +43,7 @@ abstract class DataType {
       /**
        * Enables matching against DataType for expressions:
        * {{{
    -   *   case Cast(child @ BinaryType(), StringType) =>
    +   *   case Cast(child @ DataType(), StringType) =>
    --- End diff --
    
    I'm not sure we actually want to make this change.  This is just an 
illustration of a case where this function would be used.  Matching on 
`DataType` itself is not possible, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to