Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5849#discussion_r29899220
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlSerializer2.scala
 ---
    @@ -49,7 +49,7 @@ private[sql] class Serializer2SerializationStream(
         out: OutputStream)
       extends SerializationStream with Logging {
     
    -  val rowOut = new DataOutputStream(out)
    +  val rowOut = new DataOutputStream(new BufferedOutputStream(out))
    --- End diff --
    
    Ah, nice catch; I guess that this is accounting for the fact that other 
code in Spark purposely avoids buffering under the assumption that the 
serializer does its own internal buffering; this should give a nice perf. boost 
in some cases, I imagine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to