Peng-Lei commented on a change in pull request #34093:
URL: https://github.com/apache/spark/pull/34093#discussion_r718095641
##########
File path: core/src/main/resources/error/error-classes.json
##########
@@ -110,6 +153,10 @@
"message" : [ "Unknown static partition column: %s" ],
"sqlState" : "42000"
},
+ "MISSING_STREAMING_SOURCE_SCHEMA" : {
+ "message" : [ "Schema must be specified when creating a streaming source
DataFrame. If some files already exist in the directory, then depending on the
file format you may be able to create a static DataFrame on that directory with
'spark.read.load(directory)' and infer schema from it." ],
+ "sqlState" : "3F000"
Review comment:
Agree with you. Thank you very much.
##########
File path: R/pkg/tests/fulltests/test_sparkSQL.R
##########
@@ -3873,7 +3873,8 @@ test_that("Call DataFrameWriter.save() API in Java
without path and check argume
# It makes sure that we can omit path argument in write.df API and then it
calls
# DataFrameWriter.save() without path.
expect_error(write.df(df, source = "csv"),
- "Error in save : illegal argument - Expected exactly one path to
be specified")
+ paste("Error in save :
org.apache.spark.SparkIllegalArgumentException:",
Review comment:
Thank you for the reminder.
##########
File path: core/src/main/scala/org/apache/spark/SparkException.scala
##########
@@ -72,9 +72,11 @@ private[spark] case class ExecutorDeadException(message:
String)
/**
* Exception thrown when Spark returns different result after upgrading to a
new version.
*/
-private[spark] class SparkUpgradeException(version: String, message: String,
cause: Throwable)
- extends RuntimeException("You may get a different result due to the
upgrading of Spark" +
- s" $version: $message", cause)
+private[spark] class SparkUpgradeException(
Review comment:
I just think it's private, but it is more safe that use overload instead
of modify it. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
