cloud-fan commented on a change in pull request #34137:
URL: https://github.com/apache/spark/pull/34137#discussion_r718282534
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/ShowTablesExec.scala
##########
@@ -33,7 +33,8 @@ case class ShowTablesExec(
output: Seq[Attribute],
catalog: TableCatalog,
namespace: Seq[String],
- pattern: Option[String]) extends V2CommandExec with LeafExecNode {
+ pattern: Option[String],
+ listTempViews: Option[String] => Seq[Identifier]) extends V2CommandExec
with LeafExecNode {
Review comment:
do we need to pass this? All `SparkPlan` can access the current spark
session by calling `this.session`
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowTablesSuiteBase.scala
##########
@@ -40,6 +42,10 @@ trait ShowTablesSuiteBase extends QueryTest with
DDLCommandTestUtils {
checkAnswer(df, expected)
}
+ after {
+ spark.sessionState.catalogManager.reset()
Review comment:
what's the behavior today (with v1 commands)?
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala
##########
@@ -143,6 +163,8 @@ trait ShowTablesSuiteBase extends
command.ShowTablesSuiteBase {
* The class contains tests for the `SHOW TABLES` command to check V1
In-Memory table catalog.
*/
class ShowTablesSuite extends ShowTablesSuiteBase with CommandSuiteBase {
+ override def version: String = super[ShowTablesSuiteBase].version
Review comment:
is this line needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
