sunchao commented on a change in pull request #34149:
URL: https://github.com/apache/spark/pull/34149#discussion_r719951394
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedParquetRecordReader.java
##########
@@ -320,7 +331,7 @@ private void initializeInternal() throws IOException,
UnsupportedOperationExcept
private void checkEndOfRowGroup() throws IOException {
if (rowsReturned != totalCountLoadedSoFar) return;
- PageReadStore pages = reader.readNextFilteredRowGroup();
+ PageReadStore pages = reader.readNextRowGroup();
Review comment:
yes it will, since `ParquetRowGroupReaderImpl` calls
`readNextFilteredRowGroup`. As an interface I want to make the name more
general. For instance in test we can hook it up with another class that doesn't
involve column index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
