Reamer commented on a change in pull request #34143:
URL: https://github.com/apache/spark/pull/34143#discussion_r720336905
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala
##########
@@ -88,7 +88,6 @@ private[spark] object SparkKubernetesClientFactory extends
Logging {
val config = new ConfigBuilder(autoConfigure(kubeContext.getOrElse(null)))
.withApiVersion("v1")
.withMasterUrl(master)
- .withWebsocketPingInterval(0)
Review comment:
> Are you using this code in your production?
At the moment I do not use this code in production.
> I'm wondering if there is any possibility of side-effect at the corner
case.
I don't think we will have any side effects if we remove this hardcoded
value. As I wrote, a regular ping supports the intermediate network components
to keep the session alive. Of course, we have a bit more network traffic due to
the regular ping, but that is desired.
> After this PR removes this hard-coded value, is there a way to control
this?
Because Spark uses ConfigBuilder in the following way.
```
ConfigBuilder(autoConfigure(kubeContext.getOrElse(null)))
```
and autoConfigure has the call
[`configFromSysPropsOrEnvVars(config);`](https://github.com/fabric8io/kubernetes-client/blob/61bdd64c15cb951cf6fda8260202d086d1ef16c9/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/Config.java#L273-L289),
we should be able to set a custom value via an environment variable or system
property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
