zero323 commented on a change in pull request #34136:
URL: https://github.com/apache/spark/pull/34136#discussion_r720396254
##########
File path: python/pyspark/sql/session.py
##########
@@ -107,10 +126,23 @@ class Builder(object):
"""
_lock = RLock()
- _options = {}
+ _options = {} # type: Dict[str, Any]
Review comment:
Wouldn't be better to use PEP 526 annotations here?
```python
_options: Dict[str, Any] = {}
```
I doesn't seem we're going to backport hints directly any more, and we're
already in Python 3.6 and beyond here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
