zero323 commented on a change in pull request #34151:
URL: https://github.com/apache/spark/pull/34151#discussion_r720411372
##########
File path: python/pyspark/sql/context.py
##########
@@ -104,12 +128,12 @@ def _ssql_ctx(self):
return self._jsqlContext
@property
- def _conf(self):
+ def _conf(self): # type: ignore[no-untyped-def]
"""Accessor for the JVM SQL-specific configurations"""
return self.sparkSession._jsparkSession.sessionState().conf()
@classmethod
- def getOrCreate(cls, sc):
+ def getOrCreate(cls: type, sc: SparkContext) -> SQLContext:
Review comment:
I don't think we have to annotate `cls` (same way, as won't annotate
`self`, with a few exceptions). However, if we're going to do that, we should
probably use specific type (i.e. `"Type[Foo]"`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
