rmcyang commented on a change in pull request #34158:
URL: https://github.com/apache/spark/pull/34158#discussion_r720589937
##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -2627,6 +2627,37 @@ private[spark] object Utils extends Logging {
}
}
+ // Create an instance of the class with the given name, possibly
initializing it with our conf
+ def instantiateClass[T](className: String, conf: SparkConf, isDriver:
Boolean): T = {
Review comment:
> The instantiateClassFromConf could be made private
@JoshRosen Can `instantiateClassFromConf` really made private? It's also
used to initiate Serializer instance in SparkEnv:
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/SparkEnv.scala#L301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
