venkata91 commented on a change in pull request #34156:
URL: https://github.com/apache/spark/pull/34156#discussion_r720612667
##########
File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala
##########
@@ -1447,8 +1451,9 @@ private[spark] object MapOutputTracker extends Logging {
// TODO: SPARK-35036: Instead of reading map blocks in case of AQE with
Push based shuffle,
// TODO: improve push based shuffle to read partial merged blocks
satisfying the start/end
// TODO: map indexes
- if (mergeStatuses.exists(_.nonEmpty) && startMapIndex == 0
- && endMapIndex == mapStatuses.length) {
+ if (mergeStatuses.exists(_.nonEmpty) && mergeStatuses.exists(_.exists(_ !=
null))
+ && startMapIndex == 0 && endMapIndex == mapStatuses.length) {
+ enableBatchFetch = false
Review comment:
Would it make sense to add a log line here? Would be useful for
debugging. If not `INFO` atleast `DEBUG`
##########
File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala
##########
@@ -1447,8 +1451,9 @@ private[spark] object MapOutputTracker extends Logging {
// TODO: SPARK-35036: Instead of reading map blocks in case of AQE with
Push based shuffle,
// TODO: improve push based shuffle to read partial merged blocks
satisfying the start/end
// TODO: map indexes
- if (mergeStatuses.exists(_.nonEmpty) && startMapIndex == 0
- && endMapIndex == mapStatuses.length) {
+ if (mergeStatuses.exists(_.nonEmpty) && mergeStatuses.exists(_.exists(_ !=
null))
Review comment:
does this check still makes sense `mergeStatuses.exists(_.nonEmpty)` as
it will always be `Some(Array())` when push-based shuffle flag is set to true
only will be `None` in the case when push-based shuffle flag is set to false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
