viirya commented on a change in pull request #34148:
URL: https://github.com/apache/spark/pull/34148#discussion_r720784317
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -4492,6 +4492,37 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with
SQLConfHelper with Logg
CommentOnTable(createUnresolvedTable(ctx.multipartIdentifier, "COMMENT ON
TABLE"), comment)
}
+ /**
+ * Create an index, returning a [[CreateIndex]] logical plan.
+ * For example:
+ * {{{
+ * CREATE [index_type] INDEX [index_name] ON [TABLE] table_name
(column_index_property_list)
+ * [OPTIONS indexPropertyList]
+ * column_index_property_list: column_name [OPTIONS(indexPropertyList)] [
, . . . ]
+ * indexPropertyList: index_property_name = index_property_value [ , . .
. ]
+ * }}}
+ */
+ override def visitCreateIndex(ctx: CreateIndexContext): LogicalPlan =
withOrigin(ctx) {
+ val indexName = ctx.identifier.getText
+ val indexType = if (ctx.indexType == null) "" else ctx.indexType.getText
+ val columns = ctx.columns.multipartIdentifierProperty.asScala
+ .map(_.multipartIdentifier.getText).toSeq
+ val columnsProperties = ctx.columns.multipartIdentifierProperty.asScala
+ .map(x =>
(Option(x.options).map(visitPropertyKeyValues).getOrElse(Map.empty))).toSeq
+ val options =
Option(ctx.options).map(visitPropertyKeyValues).getOrElse(Map.empty)
+
+ CreateIndex(
+ UnresolvedDBObjectName(
+ visitMultipartIdentifier(ctx.multipartIdentifier),
+ isNamespace = true),
Review comment:
We only can create index on a table, right? If so, this sounds to be
`UnresolvedTable` and we can use `createUnresolvedTable(...)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
