srowen commented on a change in pull request #34153:
URL: https://github.com/apache/spark/pull/34153#discussion_r720859545
##########
File path:
core/src/test/scala/org/apache/spark/launcher/LauncherBackendSuite.scala
##########
@@ -46,15 +46,22 @@ class LauncherBackendSuite extends SparkFunSuite with
Matchers {
private def testWithMaster(master: String): Unit = {
val env = new java.util.HashMap[String, String]()
env.put("SPARK_PRINT_LAUNCH_COMMAND", "1")
- val handle = new SparkLauncher(env)
+ val launcher = new SparkLauncher(env)
.setSparkHome(sys.props("spark.test.home"))
.setConf(SparkLauncher.DRIVER_EXTRA_CLASSPATH,
System.getProperty("java.class.path"))
.setConf(UI_ENABLED.key, "false")
.setConf(SparkLauncher.DRIVER_EXTRA_JAVA_OPTIONS,
s"-Dtest.appender=console")
.setMaster(master)
.setAppResource(SparkLauncher.NO_RESOURCE)
.setMainClass(TestApp.getClass.getName().stripSuffix("$"))
- .startApplication()
+
+ if(JavaModuleUtils.isJavaVersionAtLeast17) {
Review comment:
Rather than just add these in tests, can we ensure they get added for
Java 17 in the non-test code paths? like ensure that these args are always
added to the JVM command? that would go a long way to not disrupting users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
