xinrong-databricks commented on a change in pull request #34159:
URL: https://github.com/apache/spark/pull/34159#discussion_r721478918
##########
File path: python/pyspark/sql/conf.py
##########
@@ -26,17 +29,17 @@ class RuntimeConfig(object):
Options set here are automatically propagated to the Hadoop configuration
during I/O.
"""
- def __init__(self, jconf):
+ def __init__(self, jconf: JavaObject) -> None:
"""Create a new RuntimeConfig that wraps the underlying JVM object."""
self._jconf = jconf
@since(2.0)
- def set(self, key, value):
+ def set(self, key: str, value: str) -> None:
Review comment:
May I ask if we should keep it consistent with
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/SparkConf.scala#L82?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
