thejdeep commented on a change in pull request #34079:
URL: https://github.com/apache/spark/pull/34079#discussion_r721768729
##########
File path:
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
##########
@@ -199,11 +206,24 @@ protected void serviceInit(Configuration externalConf)
throws Exception {
_conf = new Configuration(externalConf);
URL confOverlayUrl = Thread.currentThread().getContextClassLoader()
.getResource(SHUFFLE_SERVICE_CONF_OVERLAY_RESOURCE_NAME);
+ String className = YarnShuffleService.class.getName();
if (confOverlayUrl != null) {
- logger.info("Initializing Spark YARN shuffle service with configuration
overlay from {}",
- confOverlayUrl);
_conf.addResource(confOverlayUrl);
}
+ String logsNamespace = _conf.get(SPARK_SHUFFLE_SERVICE_LOGS_NAMESPACE_KEY,
"");
+ String loggerName = logsNamespace.isEmpty() ? className : className + "."
+ logsNamespace;
+ logger = LoggerFactory.getLogger(loggerName);
Review comment:
Thanks, this is much cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
