dongjoon-hyun commented on a change in pull request #34164:
URL: https://github.com/apache/spark/pull/34164#discussion_r721874238
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala
##########
@@ -287,6 +289,42 @@ abstract class JdbcDialect extends Serializable with
Logging{
s"COMMENT ON SCHEMA ${quoteIdentifier(schema)} IS NULL"
}
+ /**
+ * Creates an index.
+ *
+ * @param indexName the name of the index to be created
+ * @param indexType the IndexType of the index to be created
Review comment:
Why do we capitalize like `the IndexType`? I expected something like the
following.
```
- @param indexType the IndexType of the index to be created
+ @param indexType the type of the index to be created
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
