viirya commented on a change in pull request #34166:
URL: https://github.com/apache/spark/pull/34166#discussion_r722792405



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/DataType.scala
##########
@@ -428,6 +428,33 @@ object DataType {
     }
   }
 
+  /**
+   * Returns true if the two data types share the same shape by name, i.e. the 
names

Review comment:
       This looks a bit opposed to `equalsStructurally` in the definition of 
"shape". Maybe just say "the two data types have same fields and order 
recursively...".




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to