HyukjinKwon commented on a change in pull request #34179:
URL: https://github.com/apache/spark/pull/34179#discussion_r722841974
##########
File path: python/pyspark/pandas/tests/test_dataframe.py
##########
@@ -6000,6 +6000,13 @@ def test_combine_first(self):
expected_pdf = pd.DataFrame({"A": [None, 0], "B": [4.0, 1.0], "C":
[3, 3]})
self.assert_eq(expected_pdf, psdf1.combine_first(psdf2))
+ def test_multi_index_dtypes(self):
Review comment:
Let's start following PySpark's convention now since we finished initial
porting. Can you add a comment with JIRA prefix? See also
https://spark.apache.org/contributing.html
##########
File path: python/pyspark/pandas/indexes/multi.py
##########
@@ -375,6 +375,13 @@ def name(self) -> Name:
def name(self, name: Name) -> None:
raise PandasNotImplementedError(class_name="pd.MultiIndex",
property_name="name")
+ @property
+ def dtypes(self) -> pd.Series:
Review comment:
Let;s also add versionadded directive in docstring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
