leesf commented on pull request #34175: URL: https://github.com/apache/spark/pull/34175#issuecomment-937673601
> Yes, this looks unused. There are several other copies of this method, which are used. I wonder if, while you're here, you can see if it makes sense to move some other copies of the method into one super-class method that's reused? not sure if it's possible. @srowen Thanks for your review. In fact `PushFoldableIntoBranchesSuite`, `SimplifyConditionalSuite` and `BooleanSimplificationSuite` use the same `assertEquivalent` but with different `relation`, and other `*Suite` do not use the same `assertEquivalent`, I think we would keep it as it is and just remove the unused `assertEquivalent`, WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
