cloud-fan commented on a change in pull request #34137:
URL: https://github.com/apache/spark/pull/34137#discussion_r724834998
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowTablesSuiteBase.scala
##########
@@ -40,6 +42,10 @@ trait ShowTablesSuiteBase extends QueryTest with
DDLCommandTestUtils {
checkAnswer(df, expected)
}
+ after {
+ spark.sessionState.catalogManager.reset()
Review comment:
Instead of calling `CatalogManager.reset` after each test, shall we find
out the tests that sets current database and set it back at the end of test?
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowTablesSuiteBase.scala
##########
@@ -40,6 +42,10 @@ trait ShowTablesSuiteBase extends QueryTest with
DDLCommandTestUtils {
checkAnswer(df, expected)
}
+ after {
+ spark.sessionState.catalogManager.reset()
Review comment:
Instead of calling `CatalogManager.reset` after each test, shall we find
out the tests that set current database and set it back at the end of test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
