cloud-fan commented on a change in pull request #34218:
URL: https://github.com/apache/spark/pull/34218#discussion_r725804468
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala
##########
@@ -733,6 +733,23 @@ private[hive] class HiveClientImpl(
Option(hivePartition).map(fromHivePartition)
}
+ override def getPartitions(
+ db: String,
+ table: String,
+ spec: Option[TablePartitionSpec]): Seq[CatalogTablePartition] =
withHiveState {
+ val hiveTable =
+ getRawTableOption(db, table).getOrElse(throw new
NoSuchTableException(db, table))
+ val partSpec = spec match {
+ case None => CatalogTypes.emptyTablePartitionSpec
+ case Some(s) =>
+ assert(s.values.forall(_.nonEmpty), s"partition spec '$s' is invalid")
+ s
+ }
+ val parts = client.getPartitions(hiveTable,
partSpec.asJava).asScala.map(fromHivePartition)
+ HiveCatalogMetrics.incrementFetchedPartitions(parts.length)
+ parts.toSeq
+ }
+
Review comment:
SGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
