cloud-fan commented on a change in pull request #34131:
URL: https://github.com/apache/spark/pull/34131#discussion_r725825221
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -398,18 +398,10 @@ class ResolveSessionCatalog(val catalogManager:
CatalogManager)
originalText,
query)
- case CreateViewStatement(
- tbl, userSpecifiedColumns, comment, properties,
- originalText, child, allowExisting, replace, viewType) =>
-
- val v1TableName = if (viewType != PersistedView) {
- // temp view doesn't belong to any catalog and we shouldn't resolve
catalog in the name.
- tbl
- } else {
- parseV1Table(tbl, "CREATE VIEW")
- }
+ case CreateTempView(nameParts, userSpecifiedColumns, comment, properties,
Review comment:
How about we create a `CreateTempViewCommand`, so that we don't need
this conversion? We can create a `CreateViewCommandBase` to share code between
`CreateTempViewCommand` and `CreateViewCommand`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
