cloud-fan commented on a change in pull request #34236:
URL: https://github.com/apache/spark/pull/34236#discussion_r725841750
##########
File path:
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/index/TableIndex.java
##########
@@ -53,27 +53,30 @@ public TableIndex(
/**
* @return the Index name.
*/
- String indexName() { return indexName; }
+ public String indexName() { return indexName; }
/**
* @return the indexType of this Index.
*/
- String indexType() { return indexType; }
+ public String indexType() { return indexType; }
/**
* @return the column(s) this Index is on. Could be multi columns (a
multi-column index).
*/
- NamedReference[] columns() { return columns; }
+ public NamedReference[] columns() { return columns; }
+
+ /**
+ * set columns using the passed in param columns
+ */
+ public void columns_(NamedReference[] columns) { this.columns = columns; }
Review comment:
this is very weird that `TableIndex` is mutable. I thought it's like a
scala case class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
