dchvn commented on a change in pull request #34238:
URL: https://github.com/apache/spark/pull/34238#discussion_r726051251
##########
File path: python/pyspark/context.py
##########
@@ -118,20 +134,36 @@ class SparkContext(object):
ValueError: ...
"""
- _gateway = None
- _jvm = None
+ _gateway = None # type: JavaGateway
+ _jvm = None # type: JavaObject
_next_accum_id = 0
- _active_spark_context = None
+ _active_spark_context = None # type: SparkContext
Review comment:
when using ```Optional```, we need resolve huge of code like
```SparkContext._jvm``` by ```ignore[union-attr]``` or check ```None```.
Could please give me a suggestion ? thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
