dchvn commented on a change in pull request #34238:
URL: https://github.com/apache/spark/pull/34238#discussion_r726403990
##########
File path: python/pyspark/conf.py
##########
@@ -118,13 +126,13 @@ def __init__(self, loadDefaults=True, _jvm=None,
_jconf=None):
if _jvm is not None:
# JVM is created, so create self._jconf directly through JVM
self._jconf = _jvm.SparkConf(loadDefaults)
- self._conf = None
+ self._conf: Dict[str, str] = None # type: ignore[assignment]
Review comment:
Thank you, updated. Could you take another look?
##########
File path: python/pyspark/context.py
##########
@@ -118,20 +134,36 @@ class SparkContext(object):
ValueError: ...
"""
- _gateway = None
- _jvm = None
+ _gateway = None # type: JavaGateway
+ _jvm = None # type: JavaObject
_next_accum_id = 0
- _active_spark_context = None
+ _active_spark_context = None # type: SparkContext
Review comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
