xinrong-databricks commented on a change in pull request #34226:
URL: https://github.com/apache/spark/pull/34226#discussion_r726638500
##########
File path: python/pyspark/sql/column.py
##########
@@ -50,7 +68,11 @@ def _to_java_column(col):
return jcol
-def _to_seq(sc, cols, converter=None):
+def _to_seq(
+ sc: SparkContext,
+ cols: Iterable["ColumnOrName"],
+ converter: Optional[Callable] = None,
Review comment:
Makes sense, updated!
##########
File path: python/pyspark/sql/column.py
##########
@@ -59,10 +81,14 @@ def _to_seq(sc, cols, converter=None):
"""
if converter:
cols = [converter(c) for c in cols]
- return sc._jvm.PythonUtils.toSeq(cols)
+ return sc._jvm.PythonUtils.toSeq(cols) # type: ignore[attr-defined]
-def _to_list(sc, cols, converter=None):
+def _to_list(
+ sc: SparkContext,
+ cols: List[Union[str, "Column"]],
+ converter: Optional[Callable] = None,
Review comment:
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
