HyukjinKwon commented on a change in pull request #34233:
URL: https://github.com/apache/spark/pull/34233#discussion_r726674423
##########
File path: python/run-tests.py
##########
@@ -98,10 +103,12 @@ def run_individual_python_test(target_dir, test_name,
pyspark_python):
]
env["PYSPARK_SUBMIT_ARGS"] = " ".join(spark_args)
- LOGGER.info("Starting test(%s): %s", pyspark_python, test_name)
+ output_prefix = get_valid_filename(pyspark_python + "__" + test_name +
"__").lstrip("_")
+ per_test_output = tempfile.NamedTemporaryFile(prefix=output_prefix,
suffix=".log")
+ LOGGER.info(
+ "Starting test(%s): %s (temp output: %s)", pyspark_python, test_name,
per_test_output.name)
Review comment:
maybe just a matter of preference .. but maybe just printing out file
name alone since it's pretty obvious .. ?
```suggestion
"Starting test(%s): %s (%s)", pyspark_python, test_name,
per_test_output.name)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
