MaxGekk commented on a change in pull request #34259:
URL: https://github.com/apache/spark/pull/34259#discussion_r727321938
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala
##########
@@ -932,7 +933,9 @@ object DDLUtils extends Logging {
_.toLowerCase(Locale.ROOT) match {
case HIVE_PROVIDER =>
val serde = table.storage.serde
- if (serde == HiveSerDe.sourceToSerDe("orc").get.serde) {
+ if (schema.exists(_.dataType.isInstanceOf[AnsiIntervalType])) {
+ throw hiveTableWithAnsiIntervalsError(table.identifier.toString)
+ } else if (serde == HiveSerDe.sourceToSerDe("orc").get.serde) {
Review comment:
I have only some concerns about the place of the check. This function is
supposed to check column names not column types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
