viirya commented on a change in pull request #34248:
URL: https://github.com/apache/spark/pull/34248#discussion_r727721767
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/parquet/ParquetScanBuilder.scala
##########
@@ -130,10 +130,10 @@ case class ParquetScanBuilder(
// are combined with filter or group by
// e.g. SELECT COUNT(col1) FROM t WHERE col2 = 8
// SELECT COUNT(col1) FROM t GROUP BY col2
- // Todo: 1. add support if groupby column is partition col
- // (https://issues.apache.org/jira/browse/SPARK-36646)
- // 2. add support if filter col is partition col
- // (https://issues.apache.org/jira/browse/SPARK-36647)
+ // However, if the filter or group by is on partition column,
+ // max/min/count can still be pushed down
Review comment:
So group by on partition column is not supported yet. Then this comment
is not correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
