dchvn commented on a change in pull request #34251:
URL: https://github.com/apache/spark/pull/34251#discussion_r727682086
##########
File path: python/pyspark/pandas/plot/core.py
##########
@@ -98,25 +98,29 @@ def set_result_text(self, ax):
)
-class HistogramPlotBase:
- @staticmethod
- def prepare_hist_data(data, bins):
- # TODO: this logic is similar with KdePlotBase. Might have to
deduplicate it.
- from pyspark.pandas.series import Series
+def _prepare_numeric_data(data):
Review comment:
Thanks, I will update this PR soon.
Can I ask a question? Why can ```python/pyspark/pandas/plot/core.py``` pass
```mypy check``` without type hint ?
##########
File path: python/pyspark/pandas/plot/core.py
##########
@@ -98,25 +98,29 @@ def set_result_text(self, ax):
)
-class HistogramPlotBase:
- @staticmethod
- def prepare_hist_data(data, bins):
- # TODO: this logic is similar with KdePlotBase. Might have to
deduplicate it.
- from pyspark.pandas.series import Series
+def _prepare_numeric_data(data):
Review comment:
Oh, it ignore in ```python/mypy.ini```
##########
File path: python/pyspark/pandas/plot/core.py
##########
@@ -98,25 +98,29 @@ def set_result_text(self, ax):
)
-class HistogramPlotBase:
- @staticmethod
- def prepare_hist_data(data, bins):
- # TODO: this logic is similar with KdePlotBase. Might have to
deduplicate it.
- from pyspark.pandas.series import Series
+def _prepare_numeric_data(data):
Review comment:
> Can we create a class called `NumericPlotBase` and define this method,
and let `HistogramPlotBase` and `KdePlotBase` inherit it?
Updated, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
