HyukjinKwon commented on a change in pull request #34273:
URL: https://github.com/apache/spark/pull/34273#discussion_r728550246
##########
File path: examples/src/main/python/als.py
##########
@@ -87,15 +87,15 @@ def update(i, mat, ratings):
for i in range(ITERATIONS):
ms = sc.parallelize(range(M), partitions) \
.map(lambda x: update(x, usb.value, Rb.value)) \
- .collect()
+ .collect() # type: ignore[assignment]
# collect() returns a list, so array ends up being
# a 3-d array, we take the first 2 dims for the matrix
- ms = matrix(np.array(ms)[:, :, 0])
+ ms = matrix(np.array(ms)[:, :, 0]) # type: ignore[assignment]
msb = sc.broadcast(ms)
us = sc.parallelize(range(U), partitions) \
.map(lambda x: update(x, msb.value, Rb.value.T)) \
- .collect()
+ .collect() # type: ignore[assignment]
Review comment:
hmmm .. I wonder if we can avoid these `ignore` in the examples ..
because the examples should better have a clean standard stuff .. do you plan
to type these examples after this PR? then I am good w/ this temporarily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
