mridulm commented on a change in pull request #34079:
URL: https://github.com/apache/spark/pull/34079#discussion_r728664139
##########
File path:
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
##########
@@ -93,7 +93,8 @@
* This {@code classpath} configuration is only supported on YARN versions >=
2.9.0.
*/
public class YarnShuffleService extends AuxiliaryService {
- private static final Logger logger =
LoggerFactory.getLogger(YarnShuffleService.class);
+ private static final Logger defaultLogger =
LoggerFactory.getLogger(YarnShuffleService.class);
+ private static Logger logger = defaultLogger;
Review comment:
This should be an instance variable, not `static`.
```suggestion
private Logger logger = defaultLogger;
```
##########
File path:
common/network-yarn/src/main/java/org/apache/spark/network/yarn/YarnShuffleService.java
##########
@@ -199,11 +206,18 @@ protected void serviceInit(Configuration externalConf)
throws Exception {
_conf = new Configuration(externalConf);
URL confOverlayUrl = Thread.currentThread().getContextClassLoader()
.getResource(SHUFFLE_SERVICE_CONF_OVERLAY_RESOURCE_NAME);
+ String className = YarnShuffleService.class.getName();
Review comment:
Move this into `if (!logsNamespace.isEmpty()) ` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
